Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
9cc927bc
authored
Sep 30, 2019
by
tonihei
Committed by
Oliver Woodman
Oct 02, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Don't block on a dead thread when waiting for messages.
PiperOrigin-RevId: 271983192
parent
7c199eb1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
11 additions
and
3 deletions
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImplInternal.java
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImplInternal.java
View file @
9cc927bc
...
@@ -210,7 +210,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
...
@@ -210,7 +210,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
@Override
@Override
public
synchronized
void
sendMessage
(
PlayerMessage
message
)
{
public
synchronized
void
sendMessage
(
PlayerMessage
message
)
{
if
(
released
)
{
if
(
released
||
!
internalPlaybackThread
.
isAlive
()
)
{
Log
.
w
(
TAG
,
"Ignoring messages sent after release."
);
Log
.
w
(
TAG
,
"Ignoring messages sent after release."
);
message
.
markAsProcessed
(
/* isDelivered= */
false
);
message
.
markAsProcessed
(
/* isDelivered= */
false
);
return
;
return
;
...
@@ -219,6 +219,9 @@ import java.util.concurrent.atomic.AtomicBoolean;
...
@@ -219,6 +219,9 @@ import java.util.concurrent.atomic.AtomicBoolean;
}
}
public
synchronized
void
setForegroundMode
(
boolean
foregroundMode
)
{
public
synchronized
void
setForegroundMode
(
boolean
foregroundMode
)
{
if
(
released
||
!
internalPlaybackThread
.
isAlive
())
{
return
;
}
if
(
foregroundMode
)
{
if
(
foregroundMode
)
{
handler
.
obtainMessage
(
MSG_SET_FOREGROUND_MODE
,
/* foregroundMode */
1
,
0
).
sendToTarget
();
handler
.
obtainMessage
(
MSG_SET_FOREGROUND_MODE
,
/* foregroundMode */
1
,
0
).
sendToTarget
();
}
else
{
}
else
{
...
@@ -227,7 +230,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
...
@@ -227,7 +230,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
.
obtainMessage
(
MSG_SET_FOREGROUND_MODE
,
/* foregroundMode */
0
,
0
,
processedFlag
)
.
obtainMessage
(
MSG_SET_FOREGROUND_MODE
,
/* foregroundMode */
0
,
0
,
processedFlag
)
.
sendToTarget
();
.
sendToTarget
();
boolean
wasInterrupted
=
false
;
boolean
wasInterrupted
=
false
;
while
(!
processedFlag
.
get
()
&&
!
released
)
{
while
(!
processedFlag
.
get
())
{
try
{
try
{
wait
();
wait
();
}
catch
(
InterruptedException
e
)
{
}
catch
(
InterruptedException
e
)
{
...
@@ -242,7 +245,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
...
@@ -242,7 +245,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
}
}
public
synchronized
void
release
()
{
public
synchronized
void
release
()
{
if
(
released
)
{
if
(
released
||
!
internalPlaybackThread
.
isAlive
()
)
{
return
;
return
;
}
}
handler
.
sendEmptyMessage
(
MSG_RELEASE
);
handler
.
sendEmptyMessage
(
MSG_RELEASE
);
...
@@ -991,6 +994,11 @@ import java.util.concurrent.atomic.AtomicBoolean;
...
@@ -991,6 +994,11 @@ import java.util.concurrent.atomic.AtomicBoolean;
private
void
sendMessageToTargetThread
(
final
PlayerMessage
message
)
{
private
void
sendMessageToTargetThread
(
final
PlayerMessage
message
)
{
Handler
handler
=
message
.
getHandler
();
Handler
handler
=
message
.
getHandler
();
if
(!
handler
.
getLooper
().
getThread
().
isAlive
())
{
Log
.
w
(
"TAG"
,
"Trying to send message on a dead thread."
);
message
.
markAsProcessed
(
/* isDelivered= */
false
);
return
;
}
handler
.
post
(
handler
.
post
(
()
->
{
()
->
{
try
{
try
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment