Commit 94713a8f by Googler Committed by Marc Baechinger

Skip transcoding if HDR video does not need encoding.

https://github.com/google/ExoPlayer/commit/3b0d2c15867b3698f130476736785d427b28b7bd made `shouldPassthrough` always return false for `enableHdrVideoEditing`:

>We force using `FrameEditor` (no passthrough) to avoid the need to select another edit operation, and use the new shaders. The `EGLContext` and `EGLSurface` also need to be set up differently for this path.

However, this was introduced before the `videoNeedsEncoding` setting was introduced in https://github.com/google/ExoPlayer/commit/3f615040c033a37f81b1d73605cd1f7d420b47b5. That setting should apply to HDR videos as much as SDR videos.

PiperOrigin-RevId: 471569853
parent bac7d697
...@@ -143,9 +143,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull; ...@@ -143,9 +143,6 @@ import org.checkerframework.checker.nullness.qual.RequiresNonNull;
if (transformationRequest.enableRequestSdrToneMapping) { if (transformationRequest.enableRequestSdrToneMapping) {
return false; return false;
} }
if (transformationRequest.enableHdrEditing) {
return false;
}
if (transformationRequest.videoMimeType != null if (transformationRequest.videoMimeType != null
&& !transformationRequest.videoMimeType.equals(inputFormat.sampleMimeType)) { && !transformationRequest.videoMimeType.equals(inputFormat.sampleMimeType)) {
return false; return false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment