Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
92269ff7
authored
Apr 17, 2019
by
aquilescanta
Committed by
Andrew Lewis
Apr 18, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Make MediaCodecRenderer#onInputFormatChanged take a FormatHolder
PiperOrigin-RevId: 244056421
parent
4d6aca76
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
16 additions
and
10 deletions
library/core/src/main/java/com/google/android/exoplayer2/audio/MediaCodecAudioRenderer.java
library/core/src/main/java/com/google/android/exoplayer2/mediacodec/MediaCodecRenderer.java
library/core/src/main/java/com/google/android/exoplayer2/video/MediaCodecVideoRenderer.java
testutils/src/main/java/com/google/android/exoplayer2/testutil/DebugRenderersFactory.java
library/core/src/main/java/com/google/android/exoplayer2/audio/MediaCodecAudioRenderer.java
View file @
92269ff7
...
...
@@ -28,6 +28,7 @@ import com.google.android.exoplayer2.C;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.ExoPlayer
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.FormatHolder
;
import
com.google.android.exoplayer2.PlaybackParameters
;
import
com.google.android.exoplayer2.PlayerMessage.Target
;
import
com.google.android.exoplayer2.audio.AudioRendererEventListener.EventDispatcher
;
...
...
@@ -419,8 +420,9 @@ public class MediaCodecAudioRenderer extends MediaCodecRenderer implements Media
}
@Override
protected
void
onInputFormatChanged
(
Format
newFormat
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
newFormat
);
protected
void
onInputFormatChanged
(
FormatHolder
formatHolder
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
formatHolder
);
Format
newFormat
=
formatHolder
.
format
;
eventDispatcher
.
inputFormatChanged
(
newFormat
);
// If the input format is anything other than PCM then we assume that the audio decoder will
// output 16-bit PCM.
...
...
library/core/src/main/java/com/google/android/exoplayer2/mediacodec/MediaCodecRenderer.java
View file @
92269ff7
...
...
@@ -726,7 +726,7 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
flagsOnlyBuffer
.
clear
();
int
result
=
readSource
(
formatHolder
,
flagsOnlyBuffer
,
requireFormat
);
if
(
result
==
C
.
RESULT_FORMAT_READ
)
{
onInputFormatChanged
(
formatHolder
.
format
);
onInputFormatChanged
(
formatHolder
);
return
true
;
}
else
if
(
result
==
C
.
RESULT_BUFFER_READ
&&
flagsOnlyBuffer
.
isEndOfStream
())
{
inputStreamEnded
=
true
;
...
...
@@ -1029,7 +1029,7 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
buffer
.
clear
();
codecReconfigurationState
=
RECONFIGURATION_STATE_WRITE_PENDING
;
}
onInputFormatChanged
(
formatHolder
.
format
);
onInputFormatChanged
(
formatHolder
);
return
true
;
}
...
...
@@ -1141,11 +1141,12 @@ public abstract class MediaCodecRenderer extends BaseRenderer {
/**
* Called when a new format is read from the upstream {@link MediaPeriod}.
*
* @param
newFormat The new format
.
* @param
formatHolder A {@link FormatHolder} that holds the new {@link Format}
.
* @throws ExoPlaybackException If an error occurs re-initializing the {@link MediaCodec}.
*/
protected
void
onInputFormatChanged
(
Format
newFormat
)
throws
ExoPlaybackException
{
protected
void
onInputFormatChanged
(
Format
Holder
formatHolder
)
throws
ExoPlaybackException
{
Format
oldFormat
=
inputFormat
;
Format
newFormat
=
formatHolder
.
format
;
inputFormat
=
newFormat
;
waitingForFirstSampleInFormat
=
true
;
...
...
library/core/src/main/java/com/google/android/exoplayer2/video/MediaCodecVideoRenderer.java
View file @
92269ff7
...
...
@@ -34,6 +34,7 @@ import com.google.android.exoplayer2.C;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.ExoPlayer
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.FormatHolder
;
import
com.google.android.exoplayer2.PlayerMessage.Target
;
import
com.google.android.exoplayer2.decoder.DecoderInputBuffer
;
import
com.google.android.exoplayer2.drm.DrmInitData
;
...
...
@@ -631,8 +632,9 @@ public class MediaCodecVideoRenderer extends MediaCodecRenderer {
}
@Override
protected
void
onInputFormatChanged
(
Format
newFormat
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
newFormat
);
protected
void
onInputFormatChanged
(
FormatHolder
formatHolder
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
formatHolder
);
Format
newFormat
=
formatHolder
.
format
;
eventDispatcher
.
inputFormatChanged
(
newFormat
);
pendingPixelWidthHeightRatio
=
newFormat
.
pixelWidthHeightRatio
;
pendingRotationDegrees
=
newFormat
.
rotationDegrees
;
...
...
testutils/src/main/java/com/google/android/exoplayer2/testutil/DebugRenderersFactory.java
View file @
92269ff7
...
...
@@ -24,6 +24,7 @@ import androidx.annotation.Nullable;
import
com.google.android.exoplayer2.DefaultRenderersFactory
;
import
com.google.android.exoplayer2.ExoPlaybackException
;
import
com.google.android.exoplayer2.Format
;
import
com.google.android.exoplayer2.FormatHolder
;
import
com.google.android.exoplayer2.Renderer
;
import
com.google.android.exoplayer2.decoder.DecoderInputBuffer
;
import
com.google.android.exoplayer2.drm.DrmSessionManager
;
...
...
@@ -141,8 +142,8 @@ public class DebugRenderersFactory extends DefaultRenderersFactory {
}
@Override
protected
void
onInputFormatChanged
(
Format
newFormat
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
newFormat
);
protected
void
onInputFormatChanged
(
Format
Holder
formatHolder
)
throws
ExoPlaybackException
{
super
.
onInputFormatChanged
(
formatHolder
);
// Ensure timestamps of buffers queued after this format change are never inserted into the
// queue of expected output timestamps before those of buffers that have already been queued.
minimumInsertIndex
=
startIndex
+
queueSize
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment