Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
8ce3d4dc
authored
Jul 25, 2022
by
bachinger
Committed by
tonihei
Aug 08, 2022
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Exclude Metadata from Format when bundling from TrackGroup
#minor-release PiperOrigin-RevId: 463062454
parent
30e5bc98
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
30 additions
and
8 deletions
libraries/common/src/main/java/androidx/media3/common/Format.java
libraries/common/src/main/java/androidx/media3/common/TrackGroup.java
libraries/common/src/test/java/androidx/media3/common/FormatTest.java
libraries/common/src/main/java/androidx/media3/common/Format.java
View file @
8ce3d4dc
...
...
@@ -1547,6 +1547,15 @@ public final class Format implements Bundleable {
@UnstableApi
@Override
public
Bundle
toBundle
()
{
return
toBundle
(
/* excludeMetadata= */
false
);
}
/**
* Returns a {@link Bundle} representing the information stored in this object. If {@code
* excludeMetadata} is true, {@linkplain Format#metadata metadata} is excluded.
*/
@UnstableApi
public
Bundle
toBundle
(
boolean
excludeMetadata
)
{
Bundle
bundle
=
new
Bundle
();
bundle
.
putString
(
keyForField
(
FIELD_ID
),
id
);
bundle
.
putString
(
keyForField
(
FIELD_LABEL
),
label
);
...
...
@@ -1556,10 +1565,10 @@ public final class Format implements Bundleable {
bundle
.
putInt
(
keyForField
(
FIELD_AVERAGE_BITRATE
),
averageBitrate
);
bundle
.
putInt
(
keyForField
(
FIELD_PEAK_BITRATE
),
peakBitrate
);
bundle
.
putString
(
keyForField
(
FIELD_CODECS
),
codecs
);
// Metadata is currently not Bundleable because Metadata.Entry is an Interface,
// which would be difficult to unbundle in a backward compatible way.
// The entries are additionally of limited usefulness to remote processes.
bundle
.
putParcelable
(
keyForField
(
FIELD_METADATA
),
metadata
);
if
(!
excludeMetadata
)
{
// TODO (internal ref: b/239701618)
bundle
.
putParcelable
(
keyForField
(
FIELD_METADATA
),
metadata
);
}
// Container specific.
bundle
.
putString
(
keyForField
(
FIELD_CONTAINER_MIME_TYPE
),
containerMimeType
);
// Sample specific.
...
...
libraries/common/src/main/java/androidx/media3/common/TrackGroup.java
View file @
8ce3d4dc
...
...
@@ -26,11 +26,11 @@ import androidx.media3.common.util.BundleableUtil;
import
androidx.media3.common.util.Log
;
import
androidx.media3.common.util.UnstableApi
;
import
com.google.common.collect.ImmutableList
;
import
com.google.common.collect.Lists
;
import
java.lang.annotation.Documented
;
import
java.lang.annotation.Retention
;
import
java.lang.annotation.RetentionPolicy
;
import
java.lang.annotation.Target
;
import
java.util.ArrayList
;
import
java.util.Arrays
;
import
java.util.List
;
...
...
@@ -179,8 +179,11 @@ public final class TrackGroup implements Bundleable {
@Override
public
Bundle
toBundle
()
{
Bundle
bundle
=
new
Bundle
();
bundle
.
putParcelableArrayList
(
keyForField
(
FIELD_FORMATS
),
BundleableUtil
.
toBundleArrayList
(
Lists
.
newArrayList
(
formats
)));
ArrayList
<
Bundle
>
arrayList
=
new
ArrayList
<>(
formats
.
length
);
for
(
Format
format
:
formats
)
{
arrayList
.
add
(
format
.
toBundle
(
/* excludeMetadata= */
true
));
}
bundle
.
putParcelableArrayList
(
keyForField
(
FIELD_FORMATS
),
arrayList
);
bundle
.
putString
(
keyForField
(
FIELD_ID
),
id
);
return
bundle
;
}
...
...
libraries/common/src/test/java/androidx/media3/common/FormatTest.java
View file @
8ce3d4dc
...
...
@@ -20,6 +20,7 @@ import static androidx.media3.common.MimeTypes.VIDEO_MP4;
import
static
androidx
.
media3
.
common
.
MimeTypes
.
VIDEO_WEBM
;
import
static
com
.
google
.
common
.
truth
.
Truth
.
assertThat
;
import
android.os.Bundle
;
import
androidx.media3.test.utils.FakeMetadataEntry
;
import
androidx.test.ext.junit.runners.AndroidJUnit4
;
import
java.util.ArrayList
;
...
...
@@ -46,6 +47,16 @@ public final class FormatTest {
assertThat
(
formatFromBundle
).
isEqualTo
(
formatToBundle
);
}
@Test
public
void
roundTripViaBundle_excludeMetadata_hasMetadataExcluded
()
{
Format
format
=
createTestFormat
();
Bundle
bundleWithMetadataExcluded
=
format
.
toBundle
(
/* excludeMetadata= */
true
);
Format
formatWithMetadataExcluded
=
Format
.
CREATOR
.
fromBundle
(
bundleWithMetadataExcluded
);
assertThat
(
formatWithMetadataExcluded
).
isEqualTo
(
format
.
buildUpon
().
setMetadata
(
null
).
build
());
}
private
static
Format
createTestFormat
()
{
byte
[]
initData1
=
new
byte
[]
{
1
,
2
,
3
};
byte
[]
initData2
=
new
byte
[]
{
4
,
5
,
6
};
...
...
@@ -60,7 +71,6 @@ public final class FormatTest {
DrmInitData
drmInitData
=
new
DrmInitData
(
drmData1
,
drmData2
);
byte
[]
projectionData
=
new
byte
[]
{
1
,
2
,
3
};
Metadata
metadata
=
new
Metadata
(
new
FakeMetadataEntry
(
"id1"
),
new
FakeMetadataEntry
(
"id2"
));
ColorInfo
colorInfo
=
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment