Skip to content

SDK / exoplayer

Go to a project
Commit 89fe0d0c by aquilescanta Committed by bachinger
Options

Make AnalyticsListener.onPlayerError take a PlaybackException 

NO_EXTERNAL

PiperOrigin-RevId: 377090819
parent a8e96da1
Inline Side-by-side
Showing with 9 additions and 10 deletions
library/core/src/main/java/com/google/android/exoplayer2/analytics/AnalyticsListener.java
...@@ -26,10 +26,10 @@ import android.view.Surface; ...@@ -26,10 +26,10 @@ import android.view.Surface;
import androidx.annotation.IntDef; import androidx.annotation.IntDef;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.ExoPlaybackException;
import com.google.android.exoplayer2.Format; import com.google.android.exoplayer2.Format;
import com.google.android.exoplayer2.MediaItem; import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.MediaMetadata; import com.google.android.exoplayer2.MediaMetadata;
import com.google.android.exoplayer2.PlaybackException;
import com.google.android.exoplayer2.PlaybackParameters; import com.google.android.exoplayer2.PlaybackParameters;
import com.google.android.exoplayer2.Player; import com.google.android.exoplayer2.Player;
import com.google.android.exoplayer2.Player.DiscontinuityReason; import com.google.android.exoplayer2.Player.DiscontinuityReason;
...@@ -617,7 +617,7 @@ public interface AnalyticsListener { ...@@ -617,7 +617,7 @@ public interface AnalyticsListener {
* @param eventTime The event time. * @param eventTime The event time.
* @param error The error. * @param error The error.
*/ */
default void onPlayerError(EventTime eventTime, ExoPlaybackException error) {} default void onPlayerError(EventTime eventTime, PlaybackException error) {}
/** /**
* Called when the available or selected tracks for the renderers changed. * Called when the available or selected tracks for the renderers changed.
......
library/core/src/main/java/com/google/android/exoplayer2/util/EventLogger.java
...@@ -21,7 +21,6 @@ import android.os.SystemClock; ...@@ -21,7 +21,6 @@ import android.os.SystemClock;
import android.text.TextUtils; import android.text.TextUtils;
import androidx.annotation.Nullable; import androidx.annotation.Nullable;
import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.ExoPlaybackException;
import com.google.android.exoplayer2.Format; import com.google.android.exoplayer2.Format;
import com.google.android.exoplayer2.MediaItem; import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.PlaybackException; import com.google.android.exoplayer2.PlaybackException;
...@@ -245,7 +244,7 @@ public class EventLogger implements AnalyticsListener { ...@@ -245,7 +244,7 @@ public class EventLogger implements AnalyticsListener {
} }
@Override @Override
public void onPlayerError(EventTime eventTime, ExoPlaybackException e) { public void onPlayerError(EventTime eventTime, PlaybackException e) {
loge(eventTime, "playerFailed", e); loge(eventTime, "playerFailed", e);
} }
......
library/core/src/test/java/com/google/android/exoplayer2/ExoPlayerTest.java
...@@ -7161,8 +7161,7 @@ public final class ExoPlayerTest { ...@@ -7161,8 +7161,7 @@ public final class ExoPlayerTest {
player.addAnalyticsListener( player.addAnalyticsListener(
new AnalyticsListener() { new AnalyticsListener() {
@Override @Override
public void onPlayerError( public void onPlayerError(EventTime eventTime, PlaybackException error) {
EventTime eventTime, ExoPlaybackException error) {
timelineAfterError.set(player.getCurrentTimeline()); timelineAfterError.set(player.getCurrentTimeline());
trackGroupsAfterError.set(player.getCurrentTrackGroups()); trackGroupsAfterError.set(player.getCurrentTrackGroups());
trackSelectionsAfterError.set(player.getCurrentTrackSelections()); trackSelectionsAfterError.set(player.getCurrentTrackSelections());
......
library/core/src/test/java/com/google/android/exoplayer2/analytics/AnalyticsCollectorTest.java
...@@ -71,6 +71,7 @@ import com.google.android.exoplayer2.C; ...@@ -71,6 +71,7 @@ import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.ExoPlaybackException; import com.google.android.exoplayer2.ExoPlaybackException;
import com.google.android.exoplayer2.Format; import com.google.android.exoplayer2.Format;
import com.google.android.exoplayer2.MediaItem; import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.PlaybackException;
import com.google.android.exoplayer2.PlaybackParameters; import com.google.android.exoplayer2.PlaybackParameters;
import com.google.android.exoplayer2.Player; import com.google.android.exoplayer2.Player;
import com.google.android.exoplayer2.Renderer; import com.google.android.exoplayer2.Renderer;
...@@ -1942,7 +1943,7 @@ public final class AnalyticsCollectorTest { ...@@ -1942,7 +1943,7 @@ public final class AnalyticsCollectorTest {
spy( spy(
new AnalyticsListener() { new AnalyticsListener() {
@Override @Override
public void onPlayerError(EventTime eventTime, ExoPlaybackException error) { public void onPlayerError(EventTime eventTime, PlaybackException error) {
analyticsCollector.onSurfaceSizeChanged(/* width= */ 0, /* height= */ 0); analyticsCollector.onSurfaceSizeChanged(/* width= */ 0, /* height= */ 0);
} }
}); });
...@@ -2141,7 +2142,7 @@ public final class AnalyticsCollectorTest { ...@@ -2141,7 +2142,7 @@ public final class AnalyticsCollectorTest {
} }
@Override @Override
public void onPlayerError(EventTime eventTime, ExoPlaybackException error) { public void onPlayerError(EventTime eventTime, PlaybackException error) {
reportedEvents.add(new ReportedEvent(EVENT_PLAYER_ERROR, eventTime)); reportedEvents.add(new ReportedEvent(EVENT_PLAYER_ERROR, eventTime));
} }
......
library/transformer/src/main/java/com/google/android/exoplayer2/transformer/Transformer.java
...@@ -37,8 +37,8 @@ import androidx.annotation.RequiresApi; ...@@ -37,8 +37,8 @@ import androidx.annotation.RequiresApi;
import androidx.annotation.VisibleForTesting; import androidx.annotation.VisibleForTesting;
import com.google.android.exoplayer2.C; import com.google.android.exoplayer2.C;
import com.google.android.exoplayer2.DefaultLoadControl; import com.google.android.exoplayer2.DefaultLoadControl;
import com.google.android.exoplayer2.ExoPlaybackException;
import com.google.android.exoplayer2.MediaItem; import com.google.android.exoplayer2.MediaItem;
import com.google.android.exoplayer2.PlaybackException;
import com.google.android.exoplayer2.Player; import com.google.android.exoplayer2.Player;
import com.google.android.exoplayer2.Renderer; import com.google.android.exoplayer2.Renderer;
import com.google.android.exoplayer2.RenderersFactory; import com.google.android.exoplayer2.RenderersFactory;
...@@ -639,7 +639,7 @@ public final class Transformer { ...@@ -639,7 +639,7 @@ public final class Transformer {
} }
@Override @Override
public void onPlayerError(EventTime eventTime, ExoPlaybackException error) { public void onPlayerError(EventTime eventTime, PlaybackException error) {
handleTransformationEnded(error); handleTransformationEnded(error);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment