Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
73813b9b
authored
Feb 05, 2019
by
andrewlewis
Committed by
Andrew Lewis
Feb 19, 2019
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Switch to non-deprecated way of setting AdDisplayContainer
PiperOrigin-RevId: 232507469
parent
0c159984
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
9 additions
and
8 deletions
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/SingletonImaFactory.java
extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java
View file @
73813b9b
...
...
@@ -465,11 +465,11 @@ public final class ImaAdsLoader
}
imaSdkSettings
.
setPlayerType
(
IMA_SDK_SETTINGS_PLAYER_TYPE
);
imaSdkSettings
.
setPlayerVersion
(
IMA_SDK_SETTINGS_PLAYER_VERSION
);
adsLoader
=
imaFactory
.
createAdsLoader
(
context
,
imaSdkSettings
);
period
=
new
Timeline
.
Period
();
adCallbacks
=
new
ArrayList
<>(
/* initialCapacity= */
1
);
adDisplayContainer
=
imaFactory
.
createAdDisplayContainer
();
adDisplayContainer
.
setPlayer
(
/* videoAdPlayer= */
this
);
adsLoader
=
imaFactory
.
createAdsLoader
(
context
,
imaSdkSettings
,
adDisplayContainer
);
adsLoader
.
addAdErrorListener
(
/* adErrorListener= */
this
);
adsLoader
.
addAdsLoadedListener
(
/* adsLoadedListener= */
this
);
fakeContentProgressElapsedRealtimeMs
=
C
.
TIME_UNSET
;
...
...
@@ -523,7 +523,6 @@ public final class ImaAdsLoader
if
(
vastLoadTimeoutMs
!=
TIMEOUT_UNSET
)
{
request
.
setVastLoadTimeout
(
vastLoadTimeoutMs
);
}
request
.
setAdDisplayContainer
(
adDisplayContainer
);
request
.
setContentProgressProvider
(
this
);
request
.
setUserRequestContext
(
pendingAdRequestContext
);
adsLoader
.
requestAds
(
request
);
...
...
@@ -1372,9 +1371,9 @@ public final class ImaAdsLoader
AdDisplayContainer
createAdDisplayContainer
();
/** @see com.google.ads.interactivemedia.v3.api.ImaSdkFactory#createAdsRequest() */
AdsRequest
createAdsRequest
();
/** @see ImaSdkFactory#createAdsLoader(Context, ImaSdkSettings) */
/** @see ImaSdkFactory#createAdsLoader(Context, ImaSdkSettings
, AdDisplayContainer
) */
com
.
google
.
ads
.
interactivemedia
.
v3
.
api
.
AdsLoader
createAdsLoader
(
Context
context
,
ImaSdkSettings
imaSdkSettings
);
Context
context
,
ImaSdkSettings
imaSdkSettings
,
AdDisplayContainer
adDisplayContainer
);
}
/** Default {@link ImaFactory} for non-test usage, which delegates to {@link ImaSdkFactory}. */
...
...
@@ -1401,8 +1400,9 @@ public final class ImaAdsLoader
@Override
public
com
.
google
.
ads
.
interactivemedia
.
v3
.
api
.
AdsLoader
createAdsLoader
(
Context
context
,
ImaSdkSettings
imaSdkSettings
)
{
return
ImaSdkFactory
.
getInstance
().
createAdsLoader
(
context
,
imaSdkSettings
);
Context
context
,
ImaSdkSettings
imaSdkSettings
,
AdDisplayContainer
adDisplayContainer
)
{
return
ImaSdkFactory
.
getInstance
()
.
createAdsLoader
(
context
,
imaSdkSettings
,
adDisplayContainer
);
}
}
}
extensions/ima/src/test/java/com/google/android/exoplayer2/ext/ima/SingletonImaFactory.java
View file @
73813b9b
...
...
@@ -17,6 +17,7 @@ package com.google.android.exoplayer2.ext.ima;
import
android.content.Context
;
import
com.google.ads.interactivemedia.v3.api.AdDisplayContainer
;
import
com.google.ads.interactivemedia.v3.api.AdsLoader
;
import
com.google.ads.interactivemedia.v3.api.AdsRenderingSettings
;
import
com.google.ads.interactivemedia.v3.api.AdsRequest
;
import
com.google.ads.interactivemedia.v3.api.ImaSdkSettings
;
...
...
@@ -64,8 +65,8 @@ final class SingletonImaFactory implements ImaAdsLoader.ImaFactory {
}
@Override
public
com
.
google
.
ads
.
interactivemedia
.
v3
.
api
.
AdsLoader
createAdsLoader
(
Context
context
,
ImaSdkSettings
imaSdkSettings
)
{
public
AdsLoader
createAdsLoader
(
Context
context
,
ImaSdkSettings
imaSdkSettings
,
AdDisplayContainer
adDisplayContainer
)
{
return
adsLoader
;
}
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment