Improve check for invalid connection request

The check currently relies on the default value of 0 returned if the Bundle doesn't define a pid. But in some cases, like Robolectric unit tests, 0 is a possible pid. The check can be improved by directly asserting that the value is defined. PiperOrigin-RevId: 521414649

Improve check for invalid connection request
The check currently relies on the default value of 0 returned if the Bundle doesn't define a pid. But in some cases, like Robolectric unit tests, 0 is a possible pid. The check can be improved by directly asserting that the value is defined. PiperOrigin-RevId: 521414649
694d690b · tonihei · Marc Baechinger · 0bfe4386 · 694d690b
Commit 694d690b authored Apr 03, 2023 by tonihei Committed by Marc Baechinger Apr 05, 2023
Showing with 2 additions and 2 deletions
libraries/session/src/main/java/androidx/media3/session/ConnectionRequest.java
--- a/libraries/session/src/main/java/androidx/media3/session/ConnectionRequest.java
+++ b/libraries/session/src/main/java/androidx/media3/session/ConnectionRequest.java
@@ -89,8 +89,8 @@ import androidx.media3.common.util.Util;
        int controllerInterfaceVersion =
            bundle.getInt(FIELD_CONTROLLER_INTERFACE_VERSION, /* defaultValue= */ 0);
        String packageName = checkNotNull(bundle.getString(FIELD_PACKAGE_NAME));
-        int pid = bundle.getInt(FIELD_PID, /* defaultValue= */ 0);
+        checkArgument(bundle.containsKey(FIELD_PID));
-        checkArgument(pid != 0);
+        int pid = bundle.getInt(FIELD_PID);
        @Nullable Bundle connectionHints = bundle.getBundle(FIELD_CONNECTION_HINTS);
        return new ConnectionRequest(
            libraryVersion,