Handle errors in all VideoAdPlayer callbacks

Some but not all VideoAdPlayer callbacks from the IMA SDK included
defensive handling of unexpected cases. Add the remaining ones.

Issue: #7492
PiperOrigin-RevId: 316082651

RELEASENOTES.md

@@ -208,7 +208,10 @@
     ([#6922](https://github.com/google/ExoPlayer/pull/6922)).
     ([#6922](https://github.com/google/ExoPlayer/pull/6922)).
 *   Cast extension: Implement playlist API and deprecate the old queue
 *   Cast extension: Implement playlist API and deprecate the old queue
     manipulation API.
     manipulation API.
-*   IMA extension: Add option to skip ads before the start position.
+*   IMA extension:
+    *   Add option to skip ads before the start position.
+    *   Catch unexpected errors in `stopAd` to avoid a crash
+        ([#7492](https://github.com/google/ExoPlayer/issues/7492)).
 *   Demo app: Retain previous position in list of samples.
 *   Demo app: Retain previous position in list of samples.
 *   Add Guava dependency.
 *   Add Guava dependency.
 
 

extensions/ima/src/main/java/com/google/android/exoplayer2/ext/ima/ImaAdsLoader.java

@@ -916,6 +916,7 @@ public final class ImaAdsLoader
       Log.w(TAG, "Unexpected playAd without stopAd");
       Log.w(TAG, "Unexpected playAd without stopAd");
     }
     }
 
 
+    try {
       if (imaAdState == IMA_AD_STATE_NONE) {
       if (imaAdState == IMA_AD_STATE_NONE) {
         // IMA is requesting to play the ad, so stop faking the content position.
         // IMA is requesting to play the ad, so stop faking the content position.
         fakeContentProgressElapsedRealtimeMs = C.TIME_UNSET;
         fakeContentProgressElapsedRealtimeMs = C.TIME_UNSET;
@@ -943,6 +944,9 @@ public final class ImaAdsLoader
       if (!Assertions.checkNotNull(player).getPlayWhenReady()) {
       if (!Assertions.checkNotNull(player).getPlayWhenReady()) {
         Assertions.checkNotNull(adsManager).pause();
         Assertions.checkNotNull(adsManager).pause();
       }
       }
+    } catch (RuntimeException e) {
+      maybeNotifyInternalError("playAd", e);
+    }
   }
   }
 
 
   @Override
   @Override
@@ -955,9 +959,9 @@ public final class ImaAdsLoader
       return;
       return;
     }
     }
 
 
+    try {
       Assertions.checkNotNull(player);
       Assertions.checkNotNull(player);
       Assertions.checkState(imaAdState != IMA_AD_STATE_NONE);
       Assertions.checkState(imaAdState != IMA_AD_STATE_NONE);
-    try {
       stopAdInternal();
       stopAdInternal();
     } catch (RuntimeException e) {
     } catch (RuntimeException e) {
       maybeNotifyInternalError("stopAd", e);
       maybeNotifyInternalError("stopAd", e);
@@ -973,11 +977,16 @@ public final class ImaAdsLoader
       // This method is called after content is resumed.
       // This method is called after content is resumed.
       return;
       return;
     }
     }
+
+    try {
       Assertions.checkState(adMediaInfo.equals(imaAdMediaInfo));
       Assertions.checkState(adMediaInfo.equals(imaAdMediaInfo));
       imaAdState = IMA_AD_STATE_PAUSED;
       imaAdState = IMA_AD_STATE_PAUSED;
       for (int i = 0; i < adCallbacks.size(); i++) {
       for (int i = 0; i < adCallbacks.size(); i++) {
         adCallbacks.get(i).onPause(adMediaInfo);
         adCallbacks.get(i).onPause(adMediaInfo);
       }
       }
+    } catch (RuntimeException e) {
+      maybeNotifyInternalError("pauseAd", e);
+    }
   }
   }
 
 
   // Player.EventListener implementation.
   // Player.EventListener implementation.