Skip to content

SDK / exoplayer

Go to a project
Commit 47e405ee by aquilescanta Committed by Oliver Woodman
Options

Add a metadata argument to Format factory methods used in HLS 

Required for propagation of HlsMetadataEntry's in chunkless preparation.

PiperOrigin-RevId: 263324345
parent b4a2f27c
Inline Side-by-side
Showing with 27 additions and 2 deletions
library/core/src/main/java/com/google/android/exoplayer2/Format.java
...@@ -168,6 +168,10 @@ public final class Format implements Parcelable { ...@@ -168,6 +168,10 @@ public final class Format implements Parcelable {
// Video. // Video.
/**
* @deprecated Use {@link #createVideoContainerFormat(String, String, String, String, String,
* Metadata, int, int, int, float, List, int, int)} instead.
*/
@Deprecated @Deprecated
public static Format createVideoContainerFormat( public static Format createVideoContainerFormat(
@Nullable String id, @Nullable String id,
...@@ -186,6 +190,7 @@ public final class Format implements Parcelable { ...@@ -186,6 +190,7 @@ public final class Format implements Parcelable {
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
width, width,
height, height,
...@@ -201,6 +206,7 @@ public final class Format implements Parcelable { ...@@ -201,6 +206,7 @@ public final class Format implements Parcelable {
@Nullable String containerMimeType, @Nullable String containerMimeType,
String sampleMimeType, String sampleMimeType,
String codecs, String codecs,
@Nullable Metadata metadata,
int bitrate, int bitrate,
int width, int width,
int height, int height,
...@@ -215,7 +221,7 @@ public final class Format implements Parcelable { ...@@ -215,7 +221,7 @@ public final class Format implements Parcelable {
roleFlags, roleFlags,
bitrate, bitrate,
codecs, codecs,
/* metadata= */ null, metadata,
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
/* maxInputSize= */ NO_VALUE, /* maxInputSize= */ NO_VALUE,
...@@ -345,6 +351,10 @@ public final class Format implements Parcelable { ...@@ -345,6 +351,10 @@ public final class Format implements Parcelable {
// Audio. // Audio.
/**
* @deprecated Use {@link #createAudioContainerFormat(String, String, String, String, String,
* Metadata, int, int, int, List, int, int, String)} instead.
*/
@Deprecated @Deprecated
public static Format createAudioContainerFormat( public static Format createAudioContainerFormat(
@Nullable String id, @Nullable String id,
...@@ -363,6 +373,7 @@ public final class Format implements Parcelable { ...@@ -363,6 +373,7 @@ public final class Format implements Parcelable {
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
channelCount, channelCount,
sampleRate, sampleRate,
...@@ -378,6 +389,7 @@ public final class Format implements Parcelable { ...@@ -378,6 +389,7 @@ public final class Format implements Parcelable {
@Nullable String containerMimeType, @Nullable String containerMimeType,
@Nullable String sampleMimeType, @Nullable String sampleMimeType,
@Nullable String codecs, @Nullable String codecs,
@Nullable Metadata metadata,
int bitrate, int bitrate,
int channelCount, int channelCount,
int sampleRate, int sampleRate,
...@@ -392,7 +404,7 @@ public final class Format implements Parcelable { ...@@ -392,7 +404,7 @@ public final class Format implements Parcelable {
roleFlags, roleFlags,
bitrate, bitrate,
codecs, codecs,
/* metadata= */ null, metadata,
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
/* maxInputSize= */ NO_VALUE, /* maxInputSize= */ NO_VALUE,
......
library/dash/src/main/java/com/google/android/exoplayer2/source/dash/manifest/DashManifestParser.java
...@@ -600,6 +600,7 @@ public class DashManifestParser extends DefaultHandler ...@@ -600,6 +600,7 @@ public class DashManifestParser extends DefaultHandler
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
width, width,
height, height,
...@@ -614,6 +615,7 @@ public class DashManifestParser extends DefaultHandler ...@@ -614,6 +615,7 @@ public class DashManifestParser extends DefaultHandler
containerMimeType, containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
audioChannels, audioChannels,
audioSamplingRate, audioSamplingRate,
......
library/dash/src/test/java/com/google/android/exoplayer2/source/dash/DashUtilTest.java
...@@ -80,6 +80,7 @@ public final class DashUtilTest { ...@@ -80,6 +80,7 @@ public final class DashUtilTest {
MimeTypes.VIDEO_MP4, MimeTypes.VIDEO_MP4,
MimeTypes.VIDEO_H264, MimeTypes.VIDEO_H264,
/* codecs= */ "", /* codecs= */ "",
/* metadata= */ null,
Format.NO_VALUE, Format.NO_VALUE,
/* width= */ 1024, /* width= */ 1024,
/* height= */ 768, /* height= */ 768,
......
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/HlsMediaPeriod.java
...@@ -773,6 +773,7 @@ public final class HlsMediaPeriod implements MediaPeriod, HlsSampleStreamWrapper ...@@ -773,6 +773,7 @@ public final class HlsMediaPeriod implements MediaPeriod, HlsSampleStreamWrapper
variantFormat.containerMimeType, variantFormat.containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
variantFormat.bitrate, variantFormat.bitrate,
variantFormat.width, variantFormat.width,
variantFormat.height, variantFormat.height,
...@@ -815,6 +816,7 @@ public final class HlsMediaPeriod implements MediaPeriod, HlsSampleStreamWrapper ...@@ -815,6 +816,7 @@ public final class HlsMediaPeriod implements MediaPeriod, HlsSampleStreamWrapper
variantFormat.containerMimeType, variantFormat.containerMimeType,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
channelCount, channelCount,
/* sampleRate= */ Format.NO_VALUE, /* sampleRate= */ Format.NO_VALUE,
......
library/hls/src/main/java/com/google/android/exoplayer2/source/hls/playlist/HlsPlaylistParser.java
...@@ -349,6 +349,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli ...@@ -349,6 +349,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
/* sampleMimeType= */ null, /* sampleMimeType= */ null,
codecs, codecs,
/* metadata= */ null,
bitrate, bitrate,
width, width,
height, height,
...@@ -422,6 +423,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli ...@@ -422,6 +423,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
/* bitrate= */ Format.NO_VALUE, /* bitrate= */ Format.NO_VALUE,
width, width,
height, height,
...@@ -451,6 +453,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli ...@@ -451,6 +453,7 @@ public final class HlsPlaylistParser implements ParsingLoadable.Parser<HlsPlayli
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
sampleMimeType, sampleMimeType,
codecs, codecs,
/* metadata= */ null,
/* bitrate= */ Format.NO_VALUE, /* bitrate= */ Format.NO_VALUE,
channelCount, channelCount,
/* sampleRate= */ Format.NO_VALUE, /* sampleRate= */ Format.NO_VALUE,
......
library/hls/src/test/java/com/google/android/exoplayer2/source/hls/HlsMediaPeriodTest.java
...@@ -127,6 +127,7 @@ public final class HlsMediaPeriodTest { ...@@ -127,6 +127,7 @@ public final class HlsMediaPeriodTest {
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
/* sampleMimeType= */ null, /* sampleMimeType= */ null,
/* codecs= */ "avc1.100.41,mp4a.40.2", /* codecs= */ "avc1.100.41,mp4a.40.2",
/* metadata= */ null,
bitrate, bitrate,
/* width= */ Format.NO_VALUE, /* width= */ Format.NO_VALUE,
/* height= */ Format.NO_VALUE, /* height= */ Format.NO_VALUE,
...@@ -144,6 +145,7 @@ public final class HlsMediaPeriodTest { ...@@ -144,6 +145,7 @@ public final class HlsMediaPeriodTest {
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
/* sampleMimeType= */ null, /* sampleMimeType= */ null,
/* codecs= */ "mp4a.40.2", /* codecs= */ "mp4a.40.2",
/* metadata= */ null,
bitrate, bitrate,
/* width= */ Format.NO_VALUE, /* width= */ Format.NO_VALUE,
/* height= */ Format.NO_VALUE, /* height= */ Format.NO_VALUE,
...@@ -176,6 +178,7 @@ public final class HlsMediaPeriodTest { ...@@ -176,6 +178,7 @@ public final class HlsMediaPeriodTest {
/* containerMimeType= */ MimeTypes.APPLICATION_M3U8, /* containerMimeType= */ MimeTypes.APPLICATION_M3U8,
MimeTypes.getMediaMimeType("mp4a.40.2"), MimeTypes.getMediaMimeType("mp4a.40.2"),
/* codecs= */ "mp4a.40.2", /* codecs= */ "mp4a.40.2",
/* metadata= */ null,
/* bitrate= */ Format.NO_VALUE, /* bitrate= */ Format.NO_VALUE,
/* channelCount= */ Format.NO_VALUE, /* channelCount= */ Format.NO_VALUE,
/* sampleRate= */ Format.NO_VALUE, /* sampleRate= */ Format.NO_VALUE,
......
library/smoothstreaming/src/main/java/com/google/android/exoplayer2/source/smoothstreaming/manifest/SsManifestParser.java
...@@ -678,6 +678,7 @@ public class SsManifestParser implements ParsingLoadable.Parser<SsManifest> { ...@@ -678,6 +678,7 @@ public class SsManifestParser implements ParsingLoadable.Parser<SsManifest> {
MimeTypes.VIDEO_MP4, MimeTypes.VIDEO_MP4,
sampleMimeType, sampleMimeType,
/* codecs= */ null, /* codecs= */ null,
/* metadata= */ null,
bitrate, bitrate,
width, width,
height, height,
...@@ -703,6 +704,7 @@ public class SsManifestParser implements ParsingLoadable.Parser<SsManifest> { ...@@ -703,6 +704,7 @@ public class SsManifestParser implements ParsingLoadable.Parser<SsManifest> {
MimeTypes.AUDIO_MP4, MimeTypes.AUDIO_MP4,
sampleMimeType, sampleMimeType,
/* codecs= */ null, /* codecs= */ null,
/* metadata= */ null,
bitrate, bitrate,
channels, channels,
samplingRate, samplingRate,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment