Commit 44044047 by ibaker Committed by tonihei

Split MediaItemTest#setSubtitles into two tests

Each test exercises one of the setters. Together they assert that both
setters set both fields.

PiperOrigin-RevId: 408309207
parent b3b4645e
...@@ -268,8 +268,8 @@ public class MediaItemTest { ...@@ -268,8 +268,8 @@ public class MediaItemTest {
} }
@Test @Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type @SuppressWarnings("deprecation") // Reading deprecated subtitles field
public void builderSetSubtitles_setsSubtitles() { public void builderSetSubtitleConfigurations() {
List<MediaItem.SubtitleConfiguration> subtitleConfigurations = List<MediaItem.SubtitleConfiguration> subtitleConfigurations =
ImmutableList.of( ImmutableList.of(
new MediaItem.SubtitleConfiguration.Builder(Uri.parse(URI_STRING + "/es")) new MediaItem.SubtitleConfiguration.Builder(Uri.parse(URI_STRING + "/es"))
...@@ -278,7 +278,24 @@ public class MediaItemTest { ...@@ -278,7 +278,24 @@ public class MediaItemTest {
.setSelectionFlags(C.SELECTION_FLAG_FORCED) .setSelectionFlags(C.SELECTION_FLAG_FORCED)
.setRoleFlags(C.ROLE_FLAG_ALTERNATE) .setRoleFlags(C.ROLE_FLAG_ALTERNATE)
.setLabel("label") .setLabel("label")
.build(), .build());
MediaItem mediaItem =
new MediaItem.Builder()
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations)
.isEqualTo(subtitleConfigurations);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
}
@Test
@SuppressWarnings("deprecation") // Using deprecated Subtitle type
public void builderSetSubtitles() {
List<MediaItem.Subtitle> subtitles =
ImmutableList.of(
new MediaItem.Subtitle( new MediaItem.Subtitle(
Uri.parse(URI_STRING + "/en"), MimeTypes.APPLICATION_TTML, /* language= */ "en"), Uri.parse(URI_STRING + "/en"), MimeTypes.APPLICATION_TTML, /* language= */ "en"),
new MediaItem.Subtitle( new MediaItem.Subtitle(
...@@ -295,14 +312,10 @@ public class MediaItemTest { ...@@ -295,14 +312,10 @@ public class MediaItemTest {
"label")); "label"));
MediaItem mediaItem = MediaItem mediaItem =
new MediaItem.Builder() new MediaItem.Builder().setUri(URI_STRING).setSubtitles(subtitles).build();
.setUri(URI_STRING)
.setSubtitleConfigurations(subtitleConfigurations)
.build();
assertThat(mediaItem.localConfiguration.subtitleConfigurations) assertThat(mediaItem.localConfiguration.subtitleConfigurations).isEqualTo(subtitles);
.isEqualTo(subtitleConfigurations); assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitles);
assertThat(mediaItem.localConfiguration.subtitles).isEqualTo(subtitleConfigurations);
} }
@Test @Test
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment