Skip to content
Toggle navigation
P
Projects
G
Groups
S
Snippets
Help
SDK
/
exoplayer
This project
Loading...
Sign in
Toggle navigation
Go to a project
Project
Repository
Issues
0
Merge Requests
0
Pipelines
Wiki
Snippets
Settings
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Commit
438bcada
authored
Feb 04, 2021
by
olly
Committed by
Oliver Woodman
Feb 09, 2021
Browse files
Options
_('Browse Files')
Download
Email Patches
Plain Diff
Consistently throw the original exception if recovery fails
PiperOrigin-RevId: 355664280
parent
a245fbdc
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
7 additions
and
13 deletions
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImplInternal.java
library/core/src/main/java/com/google/android/exoplayer2/ExoPlayerImplInternal.java
View file @
438bcada
...
...
@@ -535,7 +535,7 @@ import java.util.concurrent.atomic.AtomicBoolean;
setOffloadSchedulingEnabledInternal
(
msg
.
arg1
==
1
);
break
;
case
MSG_ATTEMPT_RENDERER_ERROR_RECOVERY:
attemptRendererErrorRecovery
(
(
ExoPlaybackException
)
msg
.
obj
);
attemptRendererErrorRecovery
();
break
;
case
MSG_RELEASE:
releaseInternal
();
...
...
@@ -563,7 +563,8 @@ import java.util.concurrent.atomic.AtomicBoolean;
handler
.
obtainMessage
(
MSG_ATTEMPT_RENDERER_ERROR_RECOVERY
,
e
));
}
else
{
if
(
pendingRecoverableRendererError
!=
null
)
{
e
.
addSuppressed
(
pendingRecoverableRendererError
);
pendingRecoverableRendererError
.
addSuppressed
(
e
);
e
=
pendingRecoverableRendererError
;
}
Log
.
e
(
TAG
,
"Playback error"
,
e
);
stopInternal
(
/* forceResetRenderers= */
true
,
/* acknowledgeStop= */
false
);
...
...
@@ -593,17 +594,6 @@ import java.util.concurrent.atomic.AtomicBoolean;
// Private methods.
private
void
attemptRendererErrorRecovery
(
ExoPlaybackException
exceptionToRecoverFrom
)
throws
ExoPlaybackException
{
Assertions
.
checkArgument
(
exceptionToRecoverFrom
.
isRecoverable
);
try
{
seekToCurrentPosition
(
/* sendDiscontinuity= */
true
);
}
catch
(
Exception
e
)
{
exceptionToRecoverFrom
.
addSuppressed
(
e
);
throw
exceptionToRecoverFrom
;
}
}
/**
* Blocks the current thread until a condition becomes true or the specified amount of time has
* elapsed.
...
...
@@ -838,6 +828,10 @@ import java.util.concurrent.atomic.AtomicBoolean;
}
}
private
void
attemptRendererErrorRecovery
()
throws
ExoPlaybackException
{
seekToCurrentPosition
(
/* sendDiscontinuity= */
true
);
}
private
void
updatePlaybackPositions
()
throws
ExoPlaybackException
{
MediaPeriodHolder
playingPeriodHolder
=
queue
.
getPlayingPeriod
();
if
(
playingPeriodHolder
==
null
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment