Commit 3a6ee77d by tofunmi Committed by microkatz

skip transformer tests if no internet connection

The failure reason (no network) will be logged in the test output, but the test will not be marked as failing, rather skipped.

PiperOrigin-RevId: 518262203
parent ea3a85f8
...@@ -18,6 +18,7 @@ package androidx.media3.transformer; ...@@ -18,6 +18,7 @@ package androidx.media3.transformer;
import static androidx.media3.common.util.Assertions.checkArgument; import static androidx.media3.common.util.Assertions.checkArgument;
import static androidx.media3.common.util.Assertions.checkNotNull; import static androidx.media3.common.util.Assertions.checkNotNull;
import static java.util.concurrent.TimeUnit.SECONDS; import static java.util.concurrent.TimeUnit.SECONDS;
import static org.junit.Assume.assumeTrue;
import android.content.Context; import android.content.Context;
import android.net.ConnectivityManager; import android.net.ConnectivityManager;
...@@ -270,17 +271,16 @@ public class TransformerAndroidTestRunner { ...@@ -270,17 +271,16 @@ public class TransformerAndroidTestRunner {
.equals(MediaItem.ClippingConfiguration.UNSET), .equals(MediaItem.ClippingConfiguration.UNSET),
"SSIM calculation is not supported for clipped inputs."); "SSIM calculation is not supported for clipped inputs.");
} }
if (!hasNetworkConnection(context)) {
for (EditedMediaItemSequence sequence : composition.sequences) { for (EditedMediaItemSequence sequence : composition.sequences) {
for (EditedMediaItem editedMediaItem : sequence.editedMediaItems) { for (EditedMediaItem editedMediaItem : sequence.editedMediaItems) {
Uri mediaItemUri = checkNotNull(editedMediaItem.mediaItem.localConfiguration).uri; Uri mediaItemUri = checkNotNull(editedMediaItem.mediaItem.localConfiguration).uri;
String scheme = checkNotNull(mediaItemUri.getScheme()); String scheme = checkNotNull(mediaItemUri.getScheme());
if ((scheme.equals("http") || scheme.equals("https"))) { if ((scheme.equals("http") || scheme.equals("https"))) {
throw new IllegalArgumentException( assumeTrue(
"Input network file requested on device with no network connection. Input file" "Input network file requested on device with no network connection. Input file"
+ " name: " + " name: "
+ mediaItemUri); + mediaItemUri,
} hasNetworkConnection(context));
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or sign in to comment